Skip to content

Fix --set-owner by calling setOwner! #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025

Conversation

pdxlocations
Copy link
Member

@pdxlocations pdxlocations commented Aug 7, 2025

This PR takes the call to setOwner out of the unmessageable conditional. It was accidentally indented in 58967e1

Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.11%. Comparing base (c60b5d4) to head (03aaa4c).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/__main__.py 81.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
- Coverage   60.13%   60.11%   -0.02%     
==========================================
  Files          24       24              
  Lines        4219     4217       -2     
==========================================
- Hits         2537     2535       -2     
  Misses       1682     1682              
Flag Coverage Δ
unittests 60.11% <81.25%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ianmcorvidae
Copy link
Contributor

Sorry to take so long on this once again, looks good I think. Will merge it now.

@ianmcorvidae ianmcorvidae merged commit 82ad9b2 into meshtastic:master Aug 18, 2025
11 checks passed
@pdxlocations
Copy link
Member Author

No worries! When you have a chance, I might recommend pushing a version patch since this is a very common command (that I broke, lol).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants